Add behavioral tests for combinational-loop analysis - #3159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds behavioral tests for the planned replacement of the combinational-loop analysis. It does not change the analyzer implementation.
Cases already handled correctly by the current implementation are active regression tests. This ensures that the replacement cannot regress existing behavior while addressing the known limitations.
Cases that currently fail are kept ignored and classified as:
The tests cover procedural control flow, strong and weak updates, bit and element regions, dynamic selections, functions and their side effects, module instances, port mappings, and incomplete analysis boundaries.
Retained-state cases that should produce
UncoveredBranchare recorded separately as follow-up work. They are not treated as combinational-loop failures and will be addressed after the combinational-loop replacement.